Scaffold accounts service with connector

[wilsonianb]

No description provided.

[chris-jackson-actionqa]

Looks like we'll be testing against a pre-populated database. No problem with that! However, will there also be test hooks to dynamically create and cleanup accounts and transactions? Seeing it's a new project, maybe add this functionality from the beginning?

Not a blocking comment. Just an observation. Feel free to ignore/resolve.

[sentientwaffle]

Rather than using non-null assertions + boot(), I suggest having an async "constructor" (a static method on App that returns a Promise<App>). The synchronous parts of the constructor can be relegated to the actual (private) constructor, which the static method would call when its done with its async setup.

[wilsonianb]

d4adcb2

[sentientwaffle]

Why assetCode!: and not assetCode: (likewise for the other fields)?

[wilsonianb]

I got this error without it and used the backend's models as guidance

error TS2564: Property 'assetCode' has no initializer and is not definitely assigned in the constructor

[sentientwaffle]

I see, I guess that's because BaseModel defines the constructor.

[sentientwaffle]

Why remove this?

[wilsonianb]

It's a duplicate of line 1.

[wilsonianb]

@sethalicious I plan on wiping the db after each accounts service test (like here). Is that what you have in mind?

I'm not sure if the tigerbeetle client currently supports resetting the db, so that may require some workarounds in the tests in the short term.

[chris-jackson-actionqa]

@sethalicious I plan on wiping the db after each accounts service test (like here). Is that what you have in mind?

I'm not sure if the tigerbeetle client currently supports resetting the db, so that may require some workarounds in the tests in the short term.

No, Im not referring to wiping the db. Actually have hooks like "POST /createTestAccount", "POST deleteTestAccount", "POST clearTransactions".

That way we can set up (and clean up) scenarios from the test instead of having to have a pre-populated database. Let the tests create the data and accounts via API calls.

[jorangreef]

I'm not sure if the tigerbeetle client currently supports resetting the db, so that may require some workarounds in the tests in the short term.

I'm not sure if we should do this at the API layer for the client or via the cli. It could be a dangerous feature if it was accidentally called by the client in production, although we could restrict usage only to config.deployment_environment == .development. We don't have this functionality yet.