-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-9: Combine Query and Quoting phases #49
Comments
Do we need a quoting phase at all? How a node (sending client or connector) decides what it thinks the cost will be to send a payment to an address is not tightly coupled to the actual sending of the payment. The node makes some decision about how much to transfer on one of it's connected ledgers when it passes that ledger a new ILP payment, how it comes to that decision isn't actually part of the protocol. I'd propose that we mention quoting as an orthogonal process that helps the node decide how much it must transfer but not make it an explicit phase in the protocol |
No, this issue proposes removing it. |
As mentioned in #65 I'm not sure whether we should combine Query + Quote or Query + Setup. The Query step goes to the receiver while the Quote goes to the connector. How could the receiver know the full path from the sender? |
I don't think quoting should be specified as part of any of the other protocols at all. Quoting is orthogonal to everything else in ITP and SPSP. It's a step in the overall process but not and end-to-end protocol. The fact that SPSP tries to handle both fixed sender and fixed receiver pricing complicates things because it means we have to fit quoting in the middle sometimes but can do it after the SPSP steps other times. Maybe we should break out and define the steps more clearly so we can be clear what steps a particular protocol handles? This would also allow us to define SPSP in terms of these steps and how the order changes if the sender or receiver price is fixed.
Which steps are required and in what order is all specific to the use case. SPSP should define how each of these are done for a well-defined set of use cases and then we should define other protocols for other use cases. |
The query phase should just include all information needed to locally calculate the behavior/cost for different amounts, to avoid a separate quoting call.
The text was updated successfully, but these errors were encountered: