Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(background/paymentSession): handle Invalid Token error #428

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jul 15, 2024

Context

Fixes #417

Changes proposed in this pull request

TO REVIEWER: Merge #429 first, and then rebase this.

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jul 15, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Jul 15, 2024

Extension builds preview

Name Link
Latest commit 27d68c2
Latest job logs Run #9952443651
BadgeDownload
BadgeDownload

@sidvishnoi
Copy link
Member Author

I realized in #426 that we may sometimes need to reuse this error detection. So, will move them out of PaymentSession and export as utils from OpenPayments file.

@sidvishnoi
Copy link
Member Author

Gonna split the PR now 😄

@raducristianpopa raducristianpopa marked this pull request as ready for review July 16, 2024 06:57
@sidvishnoi sidvishnoi merged commit 2eb9e5f into main Jul 16, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the invalid-token branch July 16, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Outgoing payment create fails with "Invalid token"
2 participants