Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - a single error message #13

Closed
julie-sullivan opened this issue Jun 28, 2019 · 1 comment · Fixed by #26
Closed

Suggestion - a single error message #13

julie-sullivan opened this issue Jun 28, 2019 · 1 comment · Fixed by #26

Comments

@julie-sullivan
Copy link
Member

This is me being lazy and not wanting to iterate! For discussion!!

This is my code snippet:

            List<Message> messages = validationResult.getErrorMessages();
            StringBuilder errorMessage = new StringBuilder();
            for (Message msg : messages) {
                errorMessage.append(msg.getMessage());
            }
            return errorMessage.toString();

I would like to do this instead:

            return validationResult.getErrorMessage();

For the strict setting we'll only have one error message anyway.

@julie-sullivan julie-sullivan changed the title Request - a single error message Suggestion - a single error message Jun 28, 2019
deepakkumar96 added a commit to deepakkumar96/biovalidator that referenced this issue Jul 7, 2019
- Add getErrorMessage() method to return single error message
  in ValidationResult. This closes intermine#13.
- Add GFF3 type in ValidatorType
- Add a helper method in ValidatorHelper for Gff3 validation
- Fix Gff errors and add few more feature attribute validation
- Add few basic Gff3 tests
@julie-sullivan
Copy link
Member Author

works as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant