Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve archive upload/download integration #23

Open
heralden opened this issue May 20, 2020 · 2 comments
Open

Improve archive upload/download integration #23

heralden opened this issue May 20, 2020 · 2 comments

Comments

@heralden
Copy link
Member

Build upon the work done in #20

I think it would be a good idea to move the code out of docker.py and into its own file, as it's not very docker related (perhaps archive.py).

We should also use envvars instead of the dict defined in the source file. We can then uncomment the function calls in commands.py and put in a statement to exit early out of the docker.upload_archives and docker.download_archives functions if the AWS envvars aren't defined.

In commands.py, I think it makes sense to place docker.upload_archives under build and docker.download_archives under start. We would then also have to modify the start process to unpack the archive and use it, instead of building from scratch (this is a slightly bigger task than the above points).

@22PoojaGaur
Copy link
Member

Hi @uosl

created a PR for this.

We should include the last part (unpack and use archive) in this PR or a separate PR?

@heralden
Copy link
Member Author

It's totally fine to include it in a separate PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants