change code as per comments #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heralden
requested changes
May 29, 2020
There was a problem hiding this comment.
Looks good! 👍
I have added one comment that we should fix before merging.
Also for the future, it would be great if you could create multiple commits with descriptive messages (change code as per comments won't make sense to anyone reading the commit log in the future 😄). Your summary of 4 points would work great as the messages of 4 separate commits.
You don't need to change this now; just keep it in mind next time you commit.
|
@uosl I will keep the point regarding commit message in mind 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uosl
This is PR for #23