-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building from path to a mine instead of git repo #29
Comments
Hi @uosl I think this would require two changes -
Does it seem fair to you? or am I missing something? |
For changes in docker-intermine-gradle, I still create a PR in the docker-intermine-repo right? (And somehow update the git submodule to fetch that version in intermine_boot?) |
👍
Not sure about this, since we'll need to make the dir available by passing it as a volume. Currently, we mount a biotestmine volume and cd into it, right? I think we should mount a volume with the dir the path points to, and cd into that (which should only be one level deep).
👍 |
oh, right. If the folder
ok. |
@uosl I added a flag for datapath (datapath is a folder under which For testing I just cloned the biotestmine repo in a datapath folder and pass datapath as command line argument. I think this is not sufficient, as other folders (eg dump, configs, packages) are required during intermine build. So my question is, in building mine from path do I assume that these folders are present and the intermine_boot just needs to start the webapp ? If not, what should I do? |
I think the datapath folder should only replace the Let me know if I misunderstood and this doesn't answer your question clearly. |
Yes, that's what I was asking. Got it. |
It seems important to be able to build a mine by its path instead of passing a git repo as an argument.
We would have to add a new argument for this, and handle it by creating a volume to mount that dir in the intermine_builder container.
The text was updated successfully, but these errors were encountered: