Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when intermine_builder fails and show better exit message #38

Closed
heralden opened this issue Jul 27, 2020 · 0 comments
Closed

Detect when intermine_builder fails and show better exit message #38

heralden opened this issue Jul 27, 2020 · 0 comments

Comments

@heralden
Copy link
Member

Build completed. Visit http://localhost:9999/biotestmine to access your mine. is always shown when intermine_builder exits. We should check for errors and replace this message with a more appropriate one when things fail.

Checking the exit code might not be enough, as I once got this when gradle failed:

   b'2020-07-16T10:31:05.874461487Z ERROR: 256\n'
   b'2020-07-16T10:31:05.874469812Z failed with exit code 0: /home/intermine/intermine/biotestmine/gradlew --stacktrace --no-daemon builddb\n'
   b'2020-07-16T10:31:05.874478152Z \n'
   b'2020-07-16T10:31:05.874486280Z check log: pbuild.log\n'
   Build completed. Visit http://localhost:9999/biotestmine to access your mine.

failed with exit code 0 sounds like it exits with code 0, which means nothing is wrong! This means we can't rely on the exit code of intermine_builder, so we'll have to check the log strings (hopefully ERROR will be enough).

@22PoojaGaur 22PoojaGaur mentioned this issue Aug 10, 2020
heralden added a commit that referenced this issue Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant