-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements.txt missing packages, causing docker build of olbase to fail #1324
Comments
okay the packages have been added to requirments_common.txt and the olbase docker image is building correctly on my machine. I created a local branch for this. If someone wants to give me permission to create a branch for this issue on the repo then I can push to this branch and then make a pull request. Also if you wanted to assign me to the issue and give it a hacktoberfest tag that would be cool too |
@Zacharius It looks like @hornc already fixed this. Sorry you weren't given credit for it. For future reference, you don't need to create the PR branch in this repo, it can be in any repo that you have commit rights to. Github knows how to do cross-repository pull requests. |
@Zacharius p.s. please do still create a PR (pull request) for your changes! @hornc submitted a hotfix to unblock you but it sounds like the solution you have working is a good one moving forward! 🎉 |
@hornc @Zacharius would this still benefit from Zachary's commits? |
super sorry for late reply. I made a pull request. Tried to follow naming scheme for my branch but I'm not sure about that. I appreciate you humoring me with the hacktoberfest tag, not sure I deserve the credit for such a low effort issue. Please let me know if I did anything incorrectly with the branch naming convention or the way I made the pull request so I can do things better in the future. |
Currently docker build of olbase fails with the message '/usr/bin/python: No module named flake8'. Pyflakes has also been identified as missing.
I believe the fix is simply adding these packages to the requirements.txt file.
The text was updated successfully, but these errors were encountered: