Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode Error rendering edition template #427

Closed
hornc opened this issue Feb 27, 2017 · 2 comments
Closed

Unicode Error rendering edition template #427

hornc opened this issue Feb 27, 2017 · 2 comments

Comments

@hornc
Copy link
Collaborator

hornc commented Feb 27, 2017 •
edited

https://openlibrary.org/books/OL25155458M/

redirects to:
https://openlibrary.org/books/OL25155458M/%E6%BC%A2%E5%AD%97%E5%8F%A4%E4%BB%8A%E9%9F%B3%E8%AB%96

Error:
/opt/openlibrary/deploys/openlibrary/7bf33ca/openlibrary/templates/type/edition/view.html: error in processing template: UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-11: ordinal not in range(128) (falling back to default template)
@hornc hornc added the unicode label May 8, 2017
@mekarpeles
Copy link
Member

Similarly https://dev.openlibrary.org/search/subjects?q=%C3%B3

@hornc hornc mentioned this issue May 10, 2017
Merged
@hornc
Copy link
Collaborator Author

hornc commented May 10, 2017

PR to fix the subject search issue: #491 The original reported issue seems to be caused by unicode in the date field: publish_date: "二〇一〇年十一月三十日，November 30, 2010"

@hornc hornc mentioned this issue May 10, 2017
Merged
mekarpeles added a commit that referenced this issue May 11, 2017
@mekarpeles
Merge pull request #492 from hornc/unicode_dates
6bbbf0f 
allow unicode/asian publish date display, fixes #427
@hornc hornc reopened this May 13, 2017
@hornc hornc closed this as completed May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hornc @mekarpeles