-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more data to Reading Log Export Option #4796
Comments
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/plugins/upstream/account.py#L884 would be a good starting point. |
Can I work on this issue? |
@shrey27tri01 Thanks for your interest. You do not need to wait for permission. If you feel like you can fix this issue then please submit a pull request. Let us know if you need any help. |
How is this effort going? Any blockers? |
@cclauss I also tried to solve this issue but the function Am I on the right track? I also thought of using this function but was getting some kind of error:
|
At the url provided above you should see |
@cclauss Sorry for the dumb question, but I'm unable to print anything on the console using |
Try |
Did that work? |
@cclaus Yes, that worked, thank you very much! |
Just a reminder that the data for these books is not in the DB so some sort of join may be necessary (or using solr). One thing we could do is provide a script which allows one to take their reading log dump and then pull all of the corresponding data. This would be a great good first issue if someone wanted to work on it. The central issue here is performance -- we're exporting the entire Reading Log which can have tens of thousands of items (and I know at least 5 reading logs which do, having done this query, lol). Joining this w/ solr data or infobase behind the scenes is problematic for the same reasons as Lists. having a separate e.g. ol-client thing or script to take the dump (offline) and then fetch the underlying items seems useful but hard to do on the website unless we kick off some offline dump like e.g. facebook does for "downloading your data". Having a javascript thing which does something like this could be a good approach (@cdrini's idea, I like it) |
@shrey27tri01 would you be still interested in taking this one? |
@tuminzee I am not currently working on this issue. You can go ahead, please. Also, really sorry for the late response :) |
Thank you for the response @shrey27tri01 |
Closed by #6621 |
I exported my reading log and the data I got:
While I did a similar export from Goodreads and the data I got:
Describe the problem that you'd like solved
So I believe we can add Title, Author, Year of Publication, Ratings, ISBN e.t.c
Stakeholders
@mekarpeles
The text was updated successfully, but these errors were encountered: