Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore: vendor/infogami/ #3885

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Oct 5, 2020

I was not successful with the proposed solution in #3636 (comment)

I keep creating PRs that pull in vendor/infogami/ which should be ignored like vendor/solr/ is. Trying to rework or recreate these PRs is frustrating.

Technical

Testing

Screenshot

Stakeholders

I was not successful with the proposed solution in #3636 (comment)
@cdrini cdrini self-assigned this Oct 5, 2020
@cclauss cclauss mentioned this pull request Oct 7, 2020
@cdrini
Copy link
Collaborator

cdrini commented Oct 8, 2020

I don't think this will do what we want 😬 If the directory has already been committed (which this has been), this doesn't prevent the file from showing up as modified. vendor/solr works because it was never committed. Can you test your flow and see if this fixes it?

@cdrini cdrini added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 8, 2020
@cclauss cclauss closed this Oct 19, 2020
@cclauss cclauss deleted the gitignore-vendor/infogami-1 branch October 19, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants