Replace urllib.urlopen with requests in loanstats.py for 2852 #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Jan 12, 2021
dherbst
deleted the
2852/refactor/replace-urlopen-with-requests-in-loanstats
branch
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…etarchive#4406) * Replace urllib.urlopen with requests in loanstats.py for 2852 * Instead of using requests.compat, import from urllib.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…etarchive#4406) * Replace urllib.urlopen with requests in loanstats.py for 2852 * Instead of using requests.compat, import from urllib.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…etarchive#4406) * Replace urllib.urlopen with requests in loanstats.py for 2852 * Instead of using requests.compat, import from urllib.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…etarchive#4406) * Replace urllib.urlopen with requests in loanstats.py for 2852 * Instead of using requests.compat, import from urllib.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…etarchive#4406) * Replace urllib.urlopen with requests in loanstats.py for 2852 * Instead of using requests.compat, import from urllib.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
…etarchive#4406) * Replace urllib.urlopen with requests in loanstats.py for 2852 * Instead of using requests.compat, import from urllib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2852
Refactor to replace
urllib.urlopenwithrequests. Also cleaned up some lint/pycodestyle warnings about formatting.Technical
Uses
requests.compatto remove theurllibimport and only userequests.Testing
Manually tested to verify the code ran as expected, and unit tests pass.
Screenshot
N/A
Stakeholders
@cclauss