Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused integration tests #8933

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Mar 21, 2024

  • remove unused integration tests
  • remove other references to integration tests

Removes dead code. I was digging around our docs and found this.
These haven't been used in a long time. I saw a message from Mek saying the tests were outdated and that was back in 2019.

If we wanted to do some integration tests we'd probably be better off starting from scratch and using modern tools.

If anyone still uses these and objects please let me know.

PS: I tried following the instructions to run them but it didn't work.

Stakeholders

@scottbarnes

@RayBB RayBB added Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] labels Mar 21, 2024
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @RayBB!

@scottbarnes scottbarnes merged commit 3739731 into master Mar 31, 2024
4 checks passed
@scottbarnes scottbarnes deleted the remove-unused-integration-tests branch March 31, 2024 14:06
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Apr 12, 2024
* remove unused integration tests

* remove other references to integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants