Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve image height for mergeUI #8939

Merged
merged 1 commit into from
Apr 1, 2024
Merged

improve image height for mergeUI #8939

merged 1 commit into from
Apr 1, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Mar 21, 2024

A very tiny improvement to the MergeUI so the images don't have a white space under them.

Before After
image image

Stakeholders

@RayBB RayBB added Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] labels Mar 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.96%. Comparing base (9a5bd10) to head (046fa4d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8939   +/-   ##
=======================================
  Coverage   15.96%   15.96%           
=======================================
  Files          89       89           
  Lines        4710     4710           
  Branches      821      821           
=======================================
  Hits          752      752           
  Misses       3449     3449           
  Partials      509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mekarpeles mekarpeles assigned cdrini and jimchamp and unassigned cdrini Mar 25, 2024
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm --- thanks, @RayBB!

@jimchamp jimchamp merged commit ed3ad85 into master Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants