Link new IA accounts to existing, previously linked OL account #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
8696/bug/fix-acct-linkage-issue
branch
from
5a570f5
to
49c1963
Compare
jimchamp
force-pushed
the
8696/bug/fix-acct-linkage-issue
branch
from
8d4fdd5
to
0143094
Compare
jimchamp
force-pushed
the
8696/bug/fix-acct-linkage-issue
branch
from
7aab662
to
0fa9f7a
Compare
jimchamp
added
the
On testing.openlibrary.org
for more information, see https://pre-commit.ci
jimchamp
changed the title
jimchamp
changed the title
|
Squash on merge. |
|
No error message is displayed when/if Google sign-in fails. In order to debug, removing this branch from testing for now. |
jimchamp
removed
the
On testing.openlibrary.org
mekarpeles
reviewed
Apr 4, 2024
This was referenced Apr 10, 2024
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Apr 12, 2024
…netarchive#8980) * Link new IA accounts to existing OL account * Log account linkage event in Sentry * Update linkage comment strings --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mek <michael.karpeles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8696
Re-establishes linkage between existing Open Library account and an IA account that has been deleted but later recreated using the same email address.
Publishes an "IA <-> OL itemname mismatch" event to sentry, which includes the old and new
itemnames in the "Additional Details" section (asol_itemnameandia_itemname, respectively).Technical
logger.errorcalls automatically publish events to Sentry (details here). Such event, however, do not contain the entire stacktrace. Additional data that is included in theextradict will appear in the event's "Additional Data" section.Important
I've only included the old and new
itemnamein these Sentry events. Will this be enough to determine if we're only entering theif ol_account and ol_account.itemnamecode block when 2 existing accounts become unlinked?An "IA <-> OL itemname mismatch" Sentry event can be found here.
The extra data can be found in this section.
Testing
I've tested this by doing the following:
On success, I was redirected to the My Books page.
When this fails, the login page is reloaded without an error message.
Screenshot
Stakeholders
@mekarpeles
@seabelis