Show error message on Google sign-in failure #9018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9019
Shows error message on Google sign-in failures.
Technical
If the response from the
/account/login.json
call is ok, we immediately redirect to the patron's account page (this is BAU). Otherwise, we display the localized error message in a newly created.note
div
.The
account/login.json
handler has been updated to return a JSON string containing the error short code and the localized error message when aBadRequest
is raised. Previously, only the error short code was returned in these cases (it wasn't even JSON encoded...).Testing
Recommend testing this before #8980 is deployed and tested.
Screenshot
Stakeholders
@mekarpeles