Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified alt text from Template to Page #9020

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Modified alt text from Template to Page #9020

merged 2 commits into from
Apr 8, 2024

Conversation

Spedi
Copy link
Contributor

@Spedi Spedi commented Apr 3, 2024

Closes #9012

Modifies the Alt text for the History button from Template to Page.

Stakeholders

@RayBB

RayBB
RayBB requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@RayBB RayBB left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

Please change the title on both pages "Edit this template"

I think the title for databarHistory and compact_title.html should probably also be changed.
Edit: Also check for other usages of "template" strings in the wrong spot if you can.

@Spedi
Copy link
Contributor Author

Spedi commented Apr 3, 2024

Found a title "Edit this template" on profile.html, should I change it to "Edit this page" too?

@RayBB
Copy link
Collaborator

RayBB commented Apr 3, 2024

@Spedi yes that makes sense to me.

RayBB
RayBB approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and it's working great. Good job!

I think that openlibrary/templates/admin/profile.html might be able to be deleted but lets not let that block this issue.

Now we just need staff to give it a final check.

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Apr 4, 2024
@RayBB RayBB mentioned this pull request Apr 4, 2024
Merged
@cdrini cdrini merged commit 26ac10c into internetarchive:master Apr 8, 2024
3 checks passed
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Apr 12, 2024
@Spedi @Achorn
Modified alt text from Template to Page (internetarchive#9020)
293c409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayBB RayBB RayBB approved these changes

Assignees

@RayBB RayBB

Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update alt text for history/edit buttons
3 participants
@Spedi @RayBB @cdrini