remove unused admin templates #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
added
the
Needs: Review
scottbarnes
approved these changes
Apr 9, 2024
scottbarnes
force-pushed
the
remove-unused-admin-templates
branch
from
22afd31
to
6a8de1f
Compare
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some empty templates when reviewing: #9020
Pretty sure these are all unused templates.
I tested this by visiting them on prod and on localhost. They all 404 (instead of permission denied)
I also did a fulltext search of the codebase for these strings:
admin/commandadmin/emailadmin/email_reassignadmin/profileAll other templates in this folder were found via one of the above methods.
Technical
Testing
Screenshot
Stakeholders