Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spanish translation #9209

Merged
merged 4 commits into from
May 3, 2024
Merged

Update Spanish translation #9209

merged 4 commits into from
May 3, 2024

Conversation

dcapillae
Copy link
Contributor

Spanish translation updated according to the latest changes in English.

@cdrini cdrini self-assigned this May 2, 2024
@cdrini
Copy link
Collaborator

cdrini commented May 2, 2024

Awesome thank you @dcapillae ! There are a few failures in the html validation for these tranlsations:

FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-Displaying stats about <strong>%(works_count)d</strong> books. Note all charts show only the top 20 bars. Note reading log stats are private.] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 109
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-Demographic statistics powered by <a href="https://www.wikidata.org/">Wikidata</a>. Here's a <a id="wd-query-sample" href="">sample</a> of the query used. <br>Improve these stats by adding the Wikidata author identifier following <a href="https://openlibrary.org/help/faq/editing.en#author-identifiers-purpose"> these instructions</a>.] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 386
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-Continue</a>.] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 59
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-<strong>Download the DAISY.zip</strong></a> for <a href="%(url)s">%(title)s</a>] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 90
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-For example: <i><a href="/subjects/cheese">cheese</a>, <a href="/subjects/roman_empire">Roman Empire</a>, <a href="/subjects/psychology">psychology</a>] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 202
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-For example: <i><a href="/subjects/person:Theodore_Roosevelt">Theodore Roosevelt</a>, <a href="/subjects/person:Julian_of_Norwich">Julian of Norwich</a>, <a href="/subjects/person:Tintin">Tintin</a>] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 249
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-For example: <i><a href="/subjects/place:London">London</a>, <a href="/subjects/place:Atlantis">Atlantis</a>, <a href="/subjects/place:Omaha">Omaha</a>] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 202
FAILED openlibrary/i18n/test_po_files.py::test_html_format[es-For example: <i><a href="/subjects/time:1984">1984</a>, <a href="/subjects/time:the_middle_ages">The Middle Ages</a>, <a href="/subjects/time:1810-1890">1810-1890</a>] - xml.etree.ElementTree.ParseError: mismatched tag: line 1, column 217

Co-authored-by: Drini Cami <cdrini@gmail.com>
@cdrini
Copy link
Collaborator

cdrini commented May 2, 2024

Ah which translations are missing </i> ? I can fix those!

We should create a new issue for the TITLE one ; for now, leave TITLE but translate the rest 👍

@dcapillae
Copy link
Contributor Author

dcapillae commented May 3, 2024

There are three strings that are missing the closing </i> code in the message.pot file, the strings starting with For example: <i> (lines 2864, 2875, 2886, 2897). I did not add it to the translation because they are also missing in the .pot file and I preferred to leave it the same so as not to break anything.

These are the translations that have not passed HTML validation, the translation strings starting with Por ejemplo: <i> (lines 3059, 3073, 3087, 3101) in the Spanish message.po file.

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I fixed most of these in #9214 ; there's still one erroring which I'm investigating 👍

openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this should be the last of them!

openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
openlibrary/i18n/es/messages.po Outdated Show resolved Hide resolved
@cdrini cdrini merged commit 4e47fb4 into internetarchive:master May 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants