Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor models/directo.rb #509

Closed
artur-intech opened this issue May 8, 2017 · 11 comments · Fixed by #1547
Closed

Refactor models/directo.rb #509

artur-intech opened this issue May 8, 2017 · 11 comments · Fixed by #1547
Assignees
Milestone

Comments

@artur-intech
Copy link
Contributor

artur-intech commented May 8, 2017

  • Consider extracting Directo into separate gem
  • Enable accounting software easy switch
  • AccountActivity > AccountEntry

#205

API spec
http://wiki.directo.ee/et/xmlcore

@vohmar
Copy link
Contributor

vohmar commented May 8, 2017

as an open source project we try to avoid .ee specific features - interface with Directo is one example of such functionality. We should design the software so that any one, including us, could easily develop interface/adapter to their preferred accounting solution. Directo solutions could be used as an example. Currently only registry project interfaces with accounting software. If the solution is easily applicable we could consider direct interfaces from regsitrars' and auction portals/applications for example.

@artur-intech
Copy link
Contributor Author

Add zones.accounting_code

@artur-intech
Copy link
Contributor Author

Log request xml, response, time

artur-intech pushed a commit that referenced this issue Nov 1, 2017
artur-intech pushed a commit that referenced this issue Nov 1, 2017
@artur-intech
Copy link
Contributor Author

artur-intech commented Nov 2, 2017

It will be needed to add the following accounting codes to zones in admin right after the release:

{"ee" => "01EE", "com.ee" => "02COM", "pri.ee" => "03PRI", "fie.ee"=>"04FIE", "med.ee" => "05MED"}

artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
Delegate AccountActivity#currency to Account

#509
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 3, 2017
artur-intech pushed a commit that referenced this issue Nov 27, 2017
artur-intech pushed a commit that referenced this issue Nov 27, 2017
artur-intech pushed a commit that referenced this issue Nov 27, 2017
artur-intech pushed a commit that referenced this issue Nov 27, 2017
artur-intech pushed a commit that referenced this issue Nov 27, 2017
artur-intech pushed a commit that referenced this issue Nov 27, 2017
artur-intech pushed a commit that referenced this issue Nov 28, 2017
artur-intech pushed a commit that referenced this issue Nov 29, 2017
@artur-intech
Copy link
Contributor Author

"Unit" => "tk", which we send to Directo is not listed in the spec we got from Directo's representative

@vohmar
Copy link
Contributor

vohmar commented Dec 6, 2017

it looks like unit is undocumented feature as it is sent to directo and invoice records all have it correctly set in Directo.

@vohmar
Copy link
Contributor

vohmar commented Dec 6, 2017

the gem has to log all the requests including the xmls sent out, responses from directo and system generated messages like errors, warnings, info messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants