WebDAV: Fix PUT to overwrite file if already exists

[adrienverge]

The WebDAV specification ¹ states that in case of a PUT /…/file, if the resource /…/file already exists and is not a collection (= a directory), then it should be replaced in place (= overwritten).

This commit fixes that.
It can be tested with a simple WebDAV client like curl:

# Write once:
curl -k -T my-file.txt https://webdav.local.internxt.com:3005
# Read:
curl -k https://webdav.local.internxt.com:3005/my-file.txt
# Overwrite (this should not fail):
curl -k -T my-file.txt https://webdav.local.internxt.com:3005

Note: I wrote this commit because otherwise the server from internxt webdav enable bugs with some WebDAV clients.

Footnotes

1. http://www.webdav.org/specs/rfc4918.html#put-resources ↩

[adrienverge]

Rebased on latest main branch.

[adrienverge]

Hello @apsantiso, @PixoDev and @larryrider, I see you worked on the WebDAV server code recently.

Could you have a look at this pull request? It fixes a real bug that prevents the use of Internxt.

Thanks :)

PS: #98 and #99 also fix bugs, and are easy to review.

[larry-internxt]

Hello @apsantiso, @PixoDev and @larryrider, I see you worked on the WebDAV server code recently.

Could you have a look at this pull request? It fixes a real bug that prevents the use of Internxt.

Thanks :)

PS: #98 and #99 also fix bugs, and are easy to review.

Hey! @adrienverge Thank you for your work, we will check it asap and if its ok it will be merged for sure!

[PixoDev]

Hey @adrienverge , thank you so much for your contribution!

I reviewed your implementation, however we don't replace file content that way (trash + delete + upload).

Instead we do the following on other platforms:

1. Check if the file exists in the Internxt API, you can check it by the UUID, you can check our existing API methods for Drive here https://github.com/internxt/sdk/blob/master/src/drive/storage/index.ts
2. In case the file exists, encrypt and reupload the file, then replace the fileId with this https://github.com/internxt/sdk/blob/master/src/drive/storage/index.ts#L630

If you need some more guidance with this, we'll be happy to help

[PixoDev]

Check our comment about replacing file content please

[adrienverge]

Thanks @larry-internxt and @PixoDev!

 however we don't replace file content that way (trash + delete + upload)

Indeed, it makes more sense to just replace without trashing.

Please see my other implementation at #107 (I open a separated PR to keep this original code somewhere, because at the moment this is the only one that allows me to use Internxt).

[adrienverge]

Hello @PixoDev, I've done the suggested implementation at #107. Could you please have a look?

[larry-internxt]

Hello @PixoDev, I've done the suggested implementation at #107. Could you please have a look?

Hey, thanks for your work! I will take a look asap

[larryrider]

Hi again @adrienverge!
This change is going to be included in the next release with some other improvements, thank you for your effort!