Update requirements.txt to remove h5py #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <47334368+gaugup@users.noreply.github.com>
gaugup
changed the title
Codecov ReportBase: 72.04% // Head: 71.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 72.04% 71.98% -0.06%
==========================================
Files 26 26
Lines 3595 3595
==========================================
- Hits 2590 2588 -2
- Misses 1005 1007 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gaugup
changed the title
amit-sharma
reviewed
Nov 18, 2022
There was a problem hiding this comment.
thanks @gaugup Shall we also remove it from environment.yml?
Signed-off-by: Gaurav Gupta <47334368+gaugup@users.noreply.github.com>
Thanks for pointing this out. Updated the PR accordingly. |
amit-sharma
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like h5py is not used as a required package in dice-ml.
Signed-off-by: Gaurav Gupta 47334368+gaugup@users.noreply.github.com