Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public_data_interface.py to add more numpy int and float types #358

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

gaugup
Copy link
Collaborator

@gaugup gaugup commented Apr 4, 2023

This is to make sure we cover more integer and float types and don't raise error.

Signed-off-by: Gaurav Gupta <47334368+gaugup@users.noreply.github.com>
@gaugup gaugup requested a review from amit-sharma as a code owner April 4, 2023 22:23
Copy link
Collaborator

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a good change to support more types.

@github-actions
Copy link

Unit Test Results

286 tests  +13   284 ✔️ +13   8m 12s ⏱️ + 1m 15s
    1 suites ±  0       2 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit d631e7d. ± Comparison against base commit f82bb51.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (f82bb51) 68.24% compared to head (d631e7d) 68.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   68.24%   68.27%   +0.02%     
==========================================
  Files          27       27              
  Lines        3603     3603              
==========================================
+ Hits         2459     2460       +1     
+ Misses       1144     1143       -1     
Flag Coverage Δ
unittests 68.27% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dice_ml/data_interfaces/public_data_interface.py 87.45% <100.00%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaugup gaugup merged commit d05c6c4 into main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants