Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct calling parameters of math.isclose() in display_df #401

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

gaugup
Copy link
Collaborator

@gaugup gaugup commented Sep 11, 2023

No description provided.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Unit Test Results

288 tests  ±0   278 ✔️ ±0   5m 35s ⏱️ +9s
    1 suites ±0     10 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 0241874. ± Comparison against base commit 838d97f.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
dice_ml/diverse_counterfactuals.py 0.00%

📢 Thoughts on this report? Let us know!.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Copy link
Collaborator

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gaugup thank you so much for fixing these errors. Apologies that I did not catch them while approving the earlier PR.
Hopefully, once the notebook tests are fixed, we can catch these errrors early.

dice_ml/diverse_counterfactuals.py Show resolved Hide resolved
dice_ml/diverse_counterfactuals.py Show resolved Hide resolved
@gaugup gaugup merged commit 45cd580 into main Sep 12, 2023
29 checks passed
@gaugup gaugup deleted the gaugup/FixFailingNBs branch September 12, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants