Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy ragged array error. #3

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

natsukium
Copy link
Contributor

Numpy 1.24.0, released over six months ago, banned the creation of implicit ragged arrays and eliminated aliases like numpy.object.
https://numpy.org/devdocs/release/1.24.0-notes.html#expired-deprecations

This PR follows those changes.

Signed-off-by: natsukium <tomoya.otabi@gmail.com>
@connortann
Copy link
Collaborator

Hi @paulbkoch , may I ask if you'd be happy to take a look at this PR?

The slicer lib is a dependency of shap, and it looks like this issue with ragged arrays may be causing trouble downstream. It doesn't look like there has been a release of slicer for several years, so I thought it would be prudent to ask if the maintainers of interpret are happy to take a look at this PR, given that the lib is under the interpretml org?

@connortann
Copy link
Collaborator

On a related note, it would be useful to have the unit tests run on CI. I believe this PR will fix slicer/test_slicer.py::test_slicer_ragged_numpy, which currently fails when run locally.

I could submit a PR to try and get it running on GitHub actions, if there are any maintainers around who could review?

@paulbkoch paulbkoch merged commit 683fd5c into interpretml:master Mar 5, 2024
@paulbkoch
Copy link
Contributor

Hi @connortann & @natsukium -- Sure, I can put out a release and can accept a PR to add GitHub actions. Are there any other changes you'd like put into the release?

@connortann
Copy link
Collaborator

That's fantastic, great to see the library is still maintained and release-able. I think the main thing is to have the issue above fixed, and ideally all the unit tests passing.

@natsukium
Copy link
Contributor Author

Thanks!

@natsukium natsukium deleted the numpy-compat branch March 8, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants