Align Docker images with source service definition #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conform with single-scoped service requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns
cardano-db-syncandcardano-db-sync-extendedDocker image interface to conform with service-scoped requirement, and adds a docker-compose file for reference. Also fixes invalid config path, previously nested underdata.The practice of defining a build and push script in each repo should be abandoned in favour of a central iohk-nix solution. For this reason, I've left any refactors to improve the design from what was implemented in https://github.com/input-output-hk/cardano-rest/tree/master/.buildkite to avoid a variance that introduces a false sense of comfort.
Draft until Docker Hub repository is setup.