Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary constructors from UMElem #4398

Open
WhatisRT opened this issue Jun 13, 2024 · 1 comment
Open

Remove unnecessary constructors from UMElem #4398

WhatisRT opened this issue Jun 13, 2024 · 1 comment
Labels
conway dijkstra Ledger era that will follow after Conway intra-era-hardfork A task that requires an intra-era hard fork simplification A nice to have improvement that simplifies the implementation

Comments

@WhatisRT
Copy link
Contributor

All elements in the UMap need to have a deposit & reward amount. So the half of the constructors that don't have that should be unused. Also, Conway removes pointer addresses, so there's no reason to keep a set of pointers around, cutting the amount of constructors in half again.
@WhatisRT WhatisRT added the simplification A nice to have improvement that simplifies the implementation label Jun 13, 2024
@lehins lehins added dijkstra Ledger era that will follow after Conway intra-era-hardfork A task that requires an intra-era hard fork conway and removed dijkstra Ledger era that will follow after Conway labels Jun 19, 2024
@lehins
Copy link
Collaborator

lehins commented Oct 28, 2024

Related ticket: #4693

In order to remove pointers from the DState, we need to turn CertState into a type family

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conway dijkstra Ledger era that will follow after Conway intra-era-hardfork A task that requires an intra-era hard fork simplification A nice to have improvement that simplifies the implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WhatisRT @lehins