Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace unmaintained angular2-uuid lib #1203

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jul 7, 2022

angular2-uuid is unmaintained and Angular has a default dependency on the uuid lib anyways, so I switched our usage to this and got rid of a (small) dependency.

AB#78020

Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a migration note and don't forget a BREAKING CHANGES: note at the merge commit.
The change itself looks nice. ;)

@MaxKless MaxKless requested a review from shauke July 7, 2022 18:14
@shauke shauke added this to the 3.0 milestone Jul 8, 2022
@shauke shauke merged commit 3c6b924 into develop Jul 8, 2022
@shauke shauke deleted the refactor/remove-angular2-uuid-lib branch July 8, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants