v1 - reintroduce support for inc/rtn under PKG resource #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds tests, but it seems that this all just works.
isc-tleavitt
requested review from
isc-bzhang,
isc-kiyer,
isc-eneil,
isc-shuliu and
isc-dchui
|
@isc-kiyer @isc-bzhang I was unable to reproduce the issues related to this that were brought up in past conversation, though I did add unit tests around the case that we were worried about (that passed without needing any related code changes beyond reintroducing the line that was removed). If you have or can find more information on why the other types were removed, that would be great. Is it possible that the source control extension could be misbehaving here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483