v1 - reintroduce support for inc/rtn under PKG resource #491
Conversation
Also adds tests, but it seems that this all just works.
isc-tleavitt
requested review from
isc-bzhang,
isc-kiyer,
isc-eneil,
isc-shuliu and
isc-dchui
|
@isc-kiyer @isc-bzhang I was unable to reproduce the issues related to this that were brought up in past conversation, though I did add unit tests around the case that we were worried about (that passed without needing any related code changes beyond reintroducing the line that was removed). If you have or can find more information on why the other types were removed, that would be great. Is it possible that the source control extension could be misbehaving here? |
|
@isc-bzhang (if you have bandwidth) @isc-kiyer (if not) bumping this back up. Would be good to know what the issues really were. |
|
@isc-kiyer @isc-shuliu bumping this up again - trying to clean up old PRs and would like to get this merged. |
There was a problem hiding this comment.
@isc-tleavitt approving with the caveat that we may need some assistance with the source control hooks when adopting to make sure everything still works fine. I do like this change since it means we can reduce the number of .INC resources we have in our module.xml
Fixes #483