Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept new versions of vue-jest for vue 2 #38

Closed
afontcu opened this issue Oct 19, 2021 · 3 comments · Fixed by #39
Closed

Accept new versions of vue-jest for vue 2 #38

afontcu opened this issue Oct 19, 2021 · 3 comments · Fixed by #39
Labels
help wanted Extra attention is needed Status: Proposal Request for comments

Comments

@afontcu
Copy link

afontcu commented Oct 19, 2021

Hi! vue-jest 4.0.1 has been released, and the current peerDep definition of -beta.3 does not include this patch version.

Also, @vue/vue2-jest has been released, and I think the following versions should be supported, too: ^27.0.0 || ^27.0.0-alpha.

I was about to open a PR but I'm not sure how to define all the 4 versions – if needed?

👋

@kazupon
Copy link
Member

kazupon commented Oct 19, 2021

@afontcu
Thank you for your feedback! :)

You’ve said, I also think that vue-i18n-jest should be supported for Vue 2 / Vue 3 and jest 26 / jest 27 like vue-jest.

Currently, vue-i18n-jest does not have a package/repo structure that takes for them.
Maybe it should be a monorepo like vue-jest. :)

And, to support vue-i18n-jest for Vue 3, this PR needs to be merged. :) /cc @lmiller1990
vuejs/vue-jest#364

@kazupon
Copy link
Member

kazupon commented Oct 20, 2021

As my comment above, I want to support.
However, I need help with this project as I am not working full-time. 🙏

If anyone is interested, please comment on this issue.

@nogic1008
You have previously contributed to vue-i18n-jest.
If you are interested, I will give you permission to be a member of this intlify project. How about it?

@afontcu
Of course, your contributions are welcome. :)

@kazupon
Copy link
Member

kazupon commented Oct 21, 2021

I've just released v1.1.1
Please check it!

Thank you for your feedback! :)

You’ve said, I also think that vue-i18n-jest should be supported for Vue 2 / Vue 3 and jest 26 / jest 27 like vue-jest.

Currently, vue-i18n-jest does not have a package/repo structure that takes for them. Maybe it should be a monorepo like vue-jest. :)

I've opened it as a new issue.
In About this, If it needs, we can discuss the below issue.
#42

Thanks!

@kazupon kazupon closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Status: Proposal Request for comments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants