This repository was archived by the owner on Dec 4, 2024. It is now read-only.
fix: Remove definition of vue-jest as peerDeps #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #38
Right now, vue-jest offers two packages to work with Vue 2:
vue-jest@4
, that supports Jest 26.@vue/vue2-jest@27
, that supports Jest 27.Since these are different packages, I'm not sure there's a smart way to define the proper peerDep definition (it would be great if it could depend on the installed Jest version).
With npm 7, having the wrong peerDeps means the installation phase will fail.
Thus, I believe not defining any
peerDeps
is the simplest fix for this problem.Another solution is to mark these packages and optional peerDeps, but I'm not sure this is any better: