Add Hashie::Extensions::Mash::DefineAccessors. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall-lee
force-pushed
the
define_accessors
branch
from
830afaa
to
161a3b4
Compare
|
I like it. Needs README/CHANGELOG. Thanks! |
|
I want this! Can I haz? |
|
Someone finish this PR please! |
|
Ok, let's do it :) |
marshall-lee
force-pushed
the
define_accessors
branch
2 times, most recently
from
413468b
to
8b8e542
Compare
This patch adds an extension for Mash that makes it behave like `OpenStruct`. It reduces overhead of `method_missing?` magic which is a good thing! It's inspired by the recent @sferik's work on `OpenStruct` — ruby/ruby#1033. When using it in `Mash` subclasses it makes them *remember* methods so then it's more like `ActiveModel` than `OpenStruct` in this case. To use it like `OpenStruct` one could use this shortcut: ```ruby { foo: 1, bar: 2 }.to_mash.with_accessors! ``` Implementation details: It injects to class an anonymous module that stores accessor method definitions. This is inspired by `ActiveModel` / `ActiveRecord`. It allows to override accessors in subclass and call them via `super` if this is intended.
marshall-lee
force-pushed
the
define_accessors
branch
from
8b8e542
to
250f174
Compare
|
@dblock it's done! |
|
I merged it. Hope @michaelherold is cool with it ;) |
|
If you're good with it, I'm good with it, my friend. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an extension for Mash that makes it behave like
OpenStruct. It reduces overhead ofmethod_missing?magic which is a good thing! It's inspired by the recent @sferik's work onOpenStruct— ruby/ruby#1033.When using it in
Mashsubclasses it makes them remember methods so then it's more likeActiveModelthanOpenStructin this case.To use it like
OpenStructone could use this shortcut:Implementation details:
It injects to class an anonymous module that stores accessor method definitions. This is inspired by
ActiveModel/ActiveRecord. It allows to override accessors in subclass and call them viasuperif this is intended.