Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #76

Merged
merged 4 commits into from
Feb 10, 2013
Merged

Various fixes #76

merged 4 commits into from
Feb 10, 2013

Conversation

rwz
Copy link
Member

@rwz rwz commented Jan 27, 2013

Also, fixes #74

@sferik
Copy link
Member

sferik commented Jan 27, 2013

Not sure about disabling quirks_mode by default. I assume some people depend on that behavior.

@rwz
Copy link
Member Author

rwz commented Jan 28, 2013

From what I've found in json_pure source code, quirks_mode is only used to enable parsing/generation of arrays/objects. And nothing else. So, the workaround is doing the same thing, but doesn't involve regexps which may fail on strings containing weird UTF8 characters.

@rwz rwz closed this Jan 28, 2013
@rwz
Copy link
Member Author

rwz commented Jan 28, 2013

Also, user may still pass quirks_mode as an option or even add it to default options.

Sorry, closed accidently

@rwz rwz reopened this Jan 28, 2013
@morgoth
Copy link
Contributor

morgoth commented Feb 10, 2013

I confirm, that it fixes problem with UTF-8 encoding

sferik added a commit that referenced this pull request Feb 10, 2013
@sferik sferik merged commit aa0c835 into intridea:master Feb 10, 2013
@sferik
Copy link
Member

sferik commented Feb 11, 2013

Also, user may still pass :quirks_mode as an option or even add it to default options.

Is this actually true? I'm taking another look at 696d594 and it appears that :quirks_mode is no longer accepted as an option. All options other than :symbolize_names appear to be dropped. I'd love to see a spec that show that options, such as :quirks_mode are successfully passed through to the adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants