Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per function invocation resolution #33

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

AdrianPell
Copy link
Contributor

Description

Adds per-function-invocation resolution of dependencies. Dependencies can be specified as follows:

  • SingleInstance() - singleton scoped to the class implementing the function
  • InstancePerLifetimeScope() - scoped to the function instance
  • otherwise - transient scope

Fixes #16

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests run successfully. New tests for this functionality still to be written.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

* Adding per-function-invocation resolution

* Fixing test issue
@rawrspace
Copy link
Member

Sorry for the delay. I just reviewed the code and it all checks out. Thanks for contributing.

@rawrspace rawrspace merged commit 51d9c0b into introtocomputerscience:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support function instance scoped DI
2 participants