Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Teams plugin for auto #1570

Merged
merged 11 commits into from
Oct 27, 2020
Merged

Microsoft Teams plugin for auto #1570

merged 11 commits into from
Oct 27, 2020

Conversation

mukul13
Copy link
Contributor

@mukul13 mukul13 commented Oct 7, 2020

What Changed

Microsoft Teams plugin for auto

Why

Microsoft teams also support incoming webhook flow. This plugin is to integrate auto with microsoft team's webhook flow

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@9.60.2-canary.1570.19802.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.60.2-canary.1570.19802.0
npm install @auto-canary/auto@9.60.2-canary.1570.19802.0
npm install @auto-canary/core@9.60.2-canary.1570.19802.0
npm install @auto-canary/all-contributors@9.60.2-canary.1570.19802.0
npm install @auto-canary/brew@9.60.2-canary.1570.19802.0
npm install @auto-canary/chrome@9.60.2-canary.1570.19802.0
npm install @auto-canary/cocoapods@9.60.2-canary.1570.19802.0
npm install @auto-canary/conventional-commits@9.60.2-canary.1570.19802.0
npm install @auto-canary/crates@9.60.2-canary.1570.19802.0
npm install @auto-canary/docker@9.60.2-canary.1570.19802.0
npm install @auto-canary/exec@9.60.2-canary.1570.19802.0
npm install @auto-canary/first-time-contributor@9.60.2-canary.1570.19802.0
npm install @auto-canary/gem@9.60.2-canary.1570.19802.0
npm install @auto-canary/gh-pages@9.60.2-canary.1570.19802.0
npm install @auto-canary/git-tag@9.60.2-canary.1570.19802.0
npm install @auto-canary/gradle@9.60.2-canary.1570.19802.0
npm install @auto-canary/jira@9.60.2-canary.1570.19802.0
npm install @auto-canary/maven@9.60.2-canary.1570.19802.0
npm install @auto-canary/microsoft-teams@9.60.2-canary.1570.19802.0
npm install @auto-canary/npm@9.60.2-canary.1570.19802.0
npm install @auto-canary/omit-commits@9.60.2-canary.1570.19802.0
npm install @auto-canary/omit-release-notes@9.60.2-canary.1570.19802.0
npm install @auto-canary/pr-body-labels@9.60.2-canary.1570.19802.0
npm install @auto-canary/released@9.60.2-canary.1570.19802.0
npm install @auto-canary/s3@9.60.2-canary.1570.19802.0
npm install @auto-canary/slack@9.60.2-canary.1570.19802.0
npm install @auto-canary/twitter@9.60.2-canary.1570.19802.0
npm install @auto-canary/upload-assets@9.60.2-canary.1570.19802.0
# or 
yarn add @auto-canary/bot-list@9.60.2-canary.1570.19802.0
yarn add @auto-canary/auto@9.60.2-canary.1570.19802.0
yarn add @auto-canary/core@9.60.2-canary.1570.19802.0
yarn add @auto-canary/all-contributors@9.60.2-canary.1570.19802.0
yarn add @auto-canary/brew@9.60.2-canary.1570.19802.0
yarn add @auto-canary/chrome@9.60.2-canary.1570.19802.0
yarn add @auto-canary/cocoapods@9.60.2-canary.1570.19802.0
yarn add @auto-canary/conventional-commits@9.60.2-canary.1570.19802.0
yarn add @auto-canary/crates@9.60.2-canary.1570.19802.0
yarn add @auto-canary/docker@9.60.2-canary.1570.19802.0
yarn add @auto-canary/exec@9.60.2-canary.1570.19802.0
yarn add @auto-canary/first-time-contributor@9.60.2-canary.1570.19802.0
yarn add @auto-canary/gem@9.60.2-canary.1570.19802.0
yarn add @auto-canary/gh-pages@9.60.2-canary.1570.19802.0
yarn add @auto-canary/git-tag@9.60.2-canary.1570.19802.0
yarn add @auto-canary/gradle@9.60.2-canary.1570.19802.0
yarn add @auto-canary/jira@9.60.2-canary.1570.19802.0
yarn add @auto-canary/maven@9.60.2-canary.1570.19802.0
yarn add @auto-canary/microsoft-teams@9.60.2-canary.1570.19802.0
yarn add @auto-canary/npm@9.60.2-canary.1570.19802.0
yarn add @auto-canary/omit-commits@9.60.2-canary.1570.19802.0
yarn add @auto-canary/omit-release-notes@9.60.2-canary.1570.19802.0
yarn add @auto-canary/pr-body-labels@9.60.2-canary.1570.19802.0
yarn add @auto-canary/released@9.60.2-canary.1570.19802.0
yarn add @auto-canary/s3@9.60.2-canary.1570.19802.0
yarn add @auto-canary/slack@9.60.2-canary.1570.19802.0
yarn add @auto-canary/twitter@9.60.2-canary.1570.19802.0
yarn add @auto-canary/upload-assets@9.60.2-canary.1570.19802.0

@adierkens adierkens added the minor Increment the minor version when merged label Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #1570 into master will decrease coverage by 0.09%.
The diff coverage is 68.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   81.22%   81.12%   -0.10%     
==========================================
  Files          60       61       +1     
  Lines        4415     4430      +15     
  Branches      938      942       +4     
==========================================
+ Hits         3586     3594       +8     
- Misses        573      577       +4     
- Partials      256      259       +3     
Impacted Files Coverage Δ
plugins/microsoft-teams/src/index.ts 58.82% <58.82%> (ø)
plugins/slack/src/index.ts 88.73% <83.33%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6ecbe...1ab9f78. Read the comment docs.

Copy link
Collaborator

@hipstersmoothie hipstersmoothie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes. I also pushed some commits to make this plugin extend from the slack plugin. If you could test this out it would be awesome!

.gitignore Outdated
@@ -213,5 +213,6 @@ GitHub.sublime-settings
### VisualStudioCode Patch ###
# Ignore all local history of files
.history
.intuitgithookrc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this please! You could probably add this to your local global .gitignire

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. will do!

```json
{
"plugins": [
// or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

@@ -0,0 +1,184 @@
import { githubToSlack } from "@atomist/slack-messages";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this package still work with microsoft teams?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it still works but I think there can be some differences in few text transformations (for example, emojis etc) between slack and Microsoft teams. It looks something like below currently
Screenshot 2020-10-12 at 6 51 19 PM

@mukul13
Copy link
Contributor Author

mukul13 commented Oct 12, 2020

will test the functionality out today in ms teams and add an update here. Apologies for the delay!

@mukul13
Copy link
Contributor Author

mukul13 commented Oct 15, 2020

@hipstersmoothie : it's working as expected with microsoft teams too currently.
a caveat: Due to recent changes, SLACK_WEBHOOK_URL variable is being used in .env for Microsoft teams instead of MICROSOFT_TEAMS_WEBHOOK_URL. Is that okay or will it be confusing?

@hipstersmoothie
Copy link
Collaborator

@mukul13 Good catch! I changed the code so it will now uses MICROSOFT_TEAMS_WEBHOOK_URL

@hipstersmoothie
Copy link
Collaborator

@mukul13 seems like I can't push to your fork anymore. mind giving me access?

@hipstersmoothie hipstersmoothie merged commit 4926371 into intuit:master Oct 27, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.61.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants