Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing PR body when it's empty #1603

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Oct 23, 2020

What Changed

see title

Why

closes #1602

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@9.60.1-canary.1603.19672.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.60.1-canary.1603.19672.0
npm install @auto-canary/auto@9.60.1-canary.1603.19672.0
npm install @auto-canary/core@9.60.1-canary.1603.19672.0
npm install @auto-canary/all-contributors@9.60.1-canary.1603.19672.0
npm install @auto-canary/brew@9.60.1-canary.1603.19672.0
npm install @auto-canary/chrome@9.60.1-canary.1603.19672.0
npm install @auto-canary/cocoapods@9.60.1-canary.1603.19672.0
npm install @auto-canary/conventional-commits@9.60.1-canary.1603.19672.0
npm install @auto-canary/crates@9.60.1-canary.1603.19672.0
npm install @auto-canary/docker@9.60.1-canary.1603.19672.0
npm install @auto-canary/exec@9.60.1-canary.1603.19672.0
npm install @auto-canary/first-time-contributor@9.60.1-canary.1603.19672.0
npm install @auto-canary/gem@9.60.1-canary.1603.19672.0
npm install @auto-canary/gh-pages@9.60.1-canary.1603.19672.0
npm install @auto-canary/git-tag@9.60.1-canary.1603.19672.0
npm install @auto-canary/gradle@9.60.1-canary.1603.19672.0
npm install @auto-canary/jira@9.60.1-canary.1603.19672.0
npm install @auto-canary/maven@9.60.1-canary.1603.19672.0
npm install @auto-canary/npm@9.60.1-canary.1603.19672.0
npm install @auto-canary/omit-commits@9.60.1-canary.1603.19672.0
npm install @auto-canary/omit-release-notes@9.60.1-canary.1603.19672.0
npm install @auto-canary/pr-body-labels@9.60.1-canary.1603.19672.0
npm install @auto-canary/released@9.60.1-canary.1603.19672.0
npm install @auto-canary/s3@9.60.1-canary.1603.19672.0
npm install @auto-canary/slack@9.60.1-canary.1603.19672.0
npm install @auto-canary/twitter@9.60.1-canary.1603.19672.0
npm install @auto-canary/upload-assets@9.60.1-canary.1603.19672.0
# or 
yarn add @auto-canary/bot-list@9.60.1-canary.1603.19672.0
yarn add @auto-canary/auto@9.60.1-canary.1603.19672.0
yarn add @auto-canary/core@9.60.1-canary.1603.19672.0
yarn add @auto-canary/all-contributors@9.60.1-canary.1603.19672.0
yarn add @auto-canary/brew@9.60.1-canary.1603.19672.0
yarn add @auto-canary/chrome@9.60.1-canary.1603.19672.0
yarn add @auto-canary/cocoapods@9.60.1-canary.1603.19672.0
yarn add @auto-canary/conventional-commits@9.60.1-canary.1603.19672.0
yarn add @auto-canary/crates@9.60.1-canary.1603.19672.0
yarn add @auto-canary/docker@9.60.1-canary.1603.19672.0
yarn add @auto-canary/exec@9.60.1-canary.1603.19672.0
yarn add @auto-canary/first-time-contributor@9.60.1-canary.1603.19672.0
yarn add @auto-canary/gem@9.60.1-canary.1603.19672.0
yarn add @auto-canary/gh-pages@9.60.1-canary.1603.19672.0
yarn add @auto-canary/git-tag@9.60.1-canary.1603.19672.0
yarn add @auto-canary/gradle@9.60.1-canary.1603.19672.0
yarn add @auto-canary/jira@9.60.1-canary.1603.19672.0
yarn add @auto-canary/maven@9.60.1-canary.1603.19672.0
yarn add @auto-canary/npm@9.60.1-canary.1603.19672.0
yarn add @auto-canary/omit-commits@9.60.1-canary.1603.19672.0
yarn add @auto-canary/omit-release-notes@9.60.1-canary.1603.19672.0
yarn add @auto-canary/pr-body-labels@9.60.1-canary.1603.19672.0
yarn add @auto-canary/released@9.60.1-canary.1603.19672.0
yarn add @auto-canary/s3@9.60.1-canary.1603.19672.0
yarn add @auto-canary/slack@9.60.1-canary.1603.19672.0
yarn add @auto-canary/twitter@9.60.1-canary.1603.19672.0
yarn add @auto-canary/upload-assets@9.60.1-canary.1603.19672.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1603 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1603   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files          60       60           
  Lines        4516     4516           
  Branches     1022     1023    +1     
=======================================
  Hits         3664     3664           
  Misses        580      580           
  Partials      272      272           
Impacted Files Coverage Δ
plugins/released/src/index.ts 87.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b60e1b...77e7365. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 0b42982 into master Oct 23, 2020
@hipstersmoothie hipstersmoothie deleted the released-plugin-bug branch October 23, 2020 21:56
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.60.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Released Plugin: Error on shipit
2 participants