Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering the task to avoid the snapshotCheck failure #2118

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Reordering the task to avoid the snapshotCheck failure #2118

merged 1 commit into from
Dec 10, 2021

Conversation

ykhandelwal913
Copy link
Collaborator

@ykhandelwal913 ykhandelwal913 commented Dec 10, 2021

What Changed

Reordering the task to avoid the snapshotCheck failure.
Calling updateVersion before checkSnapshotDependencies task to avoid failure incase of snapshot.

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.2118.25223.gz
auto-macos--canary.2118.25223.gz
auto-win.exe--canary.2118.25223.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.32.5--canary.2118.25223.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.32.5--canary.2118.25223.0
npm install @auto-canary/auto@10.32.5--canary.2118.25223.0
npm install @auto-canary/core@10.32.5--canary.2118.25223.0
npm install @auto-canary/package-json-utils@10.32.5--canary.2118.25223.0
npm install @auto-canary/all-contributors@10.32.5--canary.2118.25223.0
npm install @auto-canary/brew@10.32.5--canary.2118.25223.0
npm install @auto-canary/chrome@10.32.5--canary.2118.25223.0
npm install @auto-canary/cocoapods@10.32.5--canary.2118.25223.0
npm install @auto-canary/conventional-commits@10.32.5--canary.2118.25223.0
npm install @auto-canary/crates@10.32.5--canary.2118.25223.0
npm install @auto-canary/docker@10.32.5--canary.2118.25223.0
npm install @auto-canary/exec@10.32.5--canary.2118.25223.0
npm install @auto-canary/first-time-contributor@10.32.5--canary.2118.25223.0
npm install @auto-canary/gem@10.32.5--canary.2118.25223.0
npm install @auto-canary/gh-pages@10.32.5--canary.2118.25223.0
npm install @auto-canary/git-tag@10.32.5--canary.2118.25223.0
npm install @auto-canary/gradle@10.32.5--canary.2118.25223.0
npm install @auto-canary/jira@10.32.5--canary.2118.25223.0
npm install @auto-canary/magic-zero@10.32.5--canary.2118.25223.0
npm install @auto-canary/maven@10.32.5--canary.2118.25223.0
npm install @auto-canary/microsoft-teams@10.32.5--canary.2118.25223.0
npm install @auto-canary/npm@10.32.5--canary.2118.25223.0
npm install @auto-canary/omit-commits@10.32.5--canary.2118.25223.0
npm install @auto-canary/omit-release-notes@10.32.5--canary.2118.25223.0
npm install @auto-canary/pr-body-labels@10.32.5--canary.2118.25223.0
npm install @auto-canary/released@10.32.5--canary.2118.25223.0
npm install @auto-canary/s3@10.32.5--canary.2118.25223.0
npm install @auto-canary/sbt@10.32.5--canary.2118.25223.0
npm install @auto-canary/slack@10.32.5--canary.2118.25223.0
npm install @auto-canary/twitter@10.32.5--canary.2118.25223.0
npm install @auto-canary/upload-assets@10.32.5--canary.2118.25223.0
npm install @auto-canary/vscode@10.32.5--canary.2118.25223.0
# or 
yarn add @auto-canary/bot-list@10.32.5--canary.2118.25223.0
yarn add @auto-canary/auto@10.32.5--canary.2118.25223.0
yarn add @auto-canary/core@10.32.5--canary.2118.25223.0
yarn add @auto-canary/package-json-utils@10.32.5--canary.2118.25223.0
yarn add @auto-canary/all-contributors@10.32.5--canary.2118.25223.0
yarn add @auto-canary/brew@10.32.5--canary.2118.25223.0
yarn add @auto-canary/chrome@10.32.5--canary.2118.25223.0
yarn add @auto-canary/cocoapods@10.32.5--canary.2118.25223.0
yarn add @auto-canary/conventional-commits@10.32.5--canary.2118.25223.0
yarn add @auto-canary/crates@10.32.5--canary.2118.25223.0
yarn add @auto-canary/docker@10.32.5--canary.2118.25223.0
yarn add @auto-canary/exec@10.32.5--canary.2118.25223.0
yarn add @auto-canary/first-time-contributor@10.32.5--canary.2118.25223.0
yarn add @auto-canary/gem@10.32.5--canary.2118.25223.0
yarn add @auto-canary/gh-pages@10.32.5--canary.2118.25223.0
yarn add @auto-canary/git-tag@10.32.5--canary.2118.25223.0
yarn add @auto-canary/gradle@10.32.5--canary.2118.25223.0
yarn add @auto-canary/jira@10.32.5--canary.2118.25223.0
yarn add @auto-canary/magic-zero@10.32.5--canary.2118.25223.0
yarn add @auto-canary/maven@10.32.5--canary.2118.25223.0
yarn add @auto-canary/microsoft-teams@10.32.5--canary.2118.25223.0
yarn add @auto-canary/npm@10.32.5--canary.2118.25223.0
yarn add @auto-canary/omit-commits@10.32.5--canary.2118.25223.0
yarn add @auto-canary/omit-release-notes@10.32.5--canary.2118.25223.0
yarn add @auto-canary/pr-body-labels@10.32.5--canary.2118.25223.0
yarn add @auto-canary/released@10.32.5--canary.2118.25223.0
yarn add @auto-canary/s3@10.32.5--canary.2118.25223.0
yarn add @auto-canary/sbt@10.32.5--canary.2118.25223.0
yarn add @auto-canary/slack@10.32.5--canary.2118.25223.0
yarn add @auto-canary/twitter@10.32.5--canary.2118.25223.0
yarn add @auto-canary/upload-assets@10.32.5--canary.2118.25223.0
yarn add @auto-canary/vscode@10.32.5--canary.2118.25223.0

@sugarmanz sugarmanz added the patch Increment the patch version when merged label Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #2118 (7d8e00c) into main (123fcfd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2118   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files          66       66           
  Lines        5413     5413           
  Branches     1263     1263           
=======================================
  Hits         4341     4341           
  Misses        709      709           
  Partials      363      363           
Impacted Files Coverage Δ
plugins/gradle/src/index.ts 76.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d7568...7d8e00c. Read the comment docs.

@sugarmanz
Copy link
Collaborator

Verified with Gradle 7.0.2.

@adierkens adierkens merged commit 11021fa into intuit:main Dec 10, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.32.5 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants