Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts config loading by moving to new loader #2401

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MikeMatusz
Copy link

What Changed

Switched from the unsupported @endemolshinegroup/cosmiconfig-typescript-loader library with it's recommended replacement fork: codex-/cosmiconfig-typescript-loader.

Why

The unsupported library had conflicted ts-node dependencies that didn't allow it to work with newer versions of TypeScript.

Fixes #2248

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@jazmon
Copy link
Contributor

jazmon commented Nov 3, 2023

Would be great to see this merged! This fixes that we can use ESM in the auto.config.ts file with package.json set to "type": "module", unless I'm mistaken

@hipstersmoothie
Copy link
Collaborator

@MikeMatusz sorry for missing this. Could you update the lock file?

@MikeMatusz
Copy link
Author

MikeMatusz commented Feb 23, 2024

@hipstersmoothie Branch has been updated. Seems like pr-check and release checks failed for networking errors, not sure if that's expected or what's going on there. I see they're not required, so maybe normal.

@hipstersmoothie
Copy link
Collaborator

@MikeMatusz you can ignore those ones

@hipstersmoothie
Copy link
Collaborator

It does look like the tests need fixing though

@MikeMatusz
Copy link
Author

I get 50 failing tests just running on the main branch, so I think something might be missing from the setup guide as to how to run them. Any suggestions? I did build first (yarn, yarn build, yarn test). Some of them are related to missing GitHub token, but there's a variety, some just failing expectations. I'm on a Mac if that matters. I'd like to get this resolved, but need to be able to get a passing test run without my changes before I can troubleshoot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"npx auto info" failing with "Failed to compile TypeScript: Debug Failure" using auto.config.ts file
3 participants