Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple first-time-contributor thank you #660

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Nov 7, 2019

What Changed

Use the listContributors endpoint to determine who has contributed to the repo.

Why

Fix a bug where a contributor was thanked multiple times in the changelog.

Todo:

  • Add tests

Published PR with canary version: 7.12.7-canary.660.8528.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #660 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   88.32%   88.33%   +0.01%     
==========================================
  Files          38       38              
  Lines        2124     2126       +2     
  Branches      268      245      -23     
==========================================
+ Hits         1876     1878       +2     
  Misses        214      214              
  Partials       34       34
Impacted Files Coverage Δ
plugins/first-time-contributor/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8610c46...2283a10. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 02dfb5d into master Nov 7, 2019
@hipstersmoothie hipstersmoothie deleted the too-many-tada branch November 7, 2019 18:49
@adierkens
Copy link
Collaborator

🚀 PR was released in v7.12.8 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants