feat: Removing Unused dependencies #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatin14493
requested review from
Nishant-sehgal,
raghav-agarwal and
sks1995
as code owners
jatin14493
changed the title
| Optional<ExecutorService> executorOpt = getExecutor(executionChainConfig); | ||
| if (executorOpt.isPresent()) { | ||
| return Schedulers.from(executorOpt.get()); | ||
| private ChainHelper() { |
There was a problem hiding this comment.
can we avoid changing the formatting ?
| @@ -17,7 +17,6 @@ | |||
| <maven.compiler.target>11</maven.compiler.target> | |||
| <maven.compiler.source>11</maven.compiler.source> | |||
| <rxjava.version>2.2.16</rxjava.version> | |||
| <lombok.version>1.18.10</lombok.version> | |||
There was a problem hiding this comment.
we are using lombok, Can we check if any unused dependency exists, if not we can close the issue.
|
Stale pull request message |
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Verified that the following dependencies are not getting used anywhere in the project and can be safely removed.
Maven Plugin is unable to analyze Lombok annotations.
Noticeable issues with Lombok can arise when used in applications with Java versions > 17.
For More Details, please take a look below:
https://blogs.oracle.com/javamagazine/post/a-peek-into-java-17-continuing-the-drive-to-encapsulate-the-java-runtime-internals