BailHook default handler #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugarmanz
reviewed
Jun 1, 2023
| } | ||
| } | ||
|
|
||
| default?.invoke(p1) |
There was a problem hiding this comment.
I think this'd be return default?.invoke(p1)
| @@ -6,16 +6,18 @@ public sealed class BailResult<T> { | |||
| public class Continue<T> : BailResult<T>() | |||
| } | |||
|
|
|||
| public abstract class SyncBailHook<F : Function<BailResult<R>>, R> : SyncBaseHook<F>("SyncBailHook") { | |||
| protected fun call(invokeWithContext: (F, HookContext) -> BailResult<R>): R? { | |||
| public abstract class SyncBailHook<T, F : (HookContext, T) -> BailResult<R>, R> : SyncBaseHook<F>("SyncBailHook") { | |||
There was a problem hiding this comment.
We can't assume arity here. This is explicitly Function, because that type is arity-less. I'm not sure we need to change anything in the base definition.
| public abstract class SyncBailHook<F : Function<BailResult<R>>, R> : SyncBaseHook<F>("SyncBailHook") { | ||
| protected fun call(invokeWithContext: (F, HookContext) -> BailResult<R>): R? { | ||
| public abstract class SyncBailHook<T, F : (HookContext, T) -> BailResult<R>, R> : SyncBaseHook<F>("SyncBailHook") { | ||
| protected fun call(invokeWithContext: (F, HookContext) -> BailResult<R>, default: ((T) -> Unit)? = null, p1: T): R? { |
There was a problem hiding this comment.
The type of default would probably be F. If we don't want the return type to be bounded to BailResult, then we'd need to add another type param for the SyncBailHook to capture the type of the default F.
sugarmanz
reviewed
Jun 2, 2023
processor/src/main/kotlin/com/intuit/hooks/plugin/codegen/Poet.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremiah Zucker <zucker.jeremiah@gmail.com>
sugarmanz
approved these changes
Jun 2, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Added a default handler to SyncBailHook
callto automatically handle non-bail casesWhy
Provide a default behaviour for when all the taps continue
Todo:
Release Notes
Allows for
SyncBailHookto call with a default handler for when the taps do not bail and return nothing📦 Published PR as canary version:
0.14.1-canary.33.352-SNAPSHOT