Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions in list view leads to 404 #145

Closed
fzxu opened this issue Mar 18, 2019 · 2 comments
Closed

Actions in list view leads to 404 #145

fzxu opened this issue Mar 18, 2019 · 2 comments
Assignees
Labels
bug Something isn't working size: 1 sprint22 UI front-end related

Comments

@fzxu
Copy link
Collaborator

fzxu commented Mar 18, 2019

The graph action in list view will lead to 404.

re-produce: https://dev-devx-cmdb-api-qal.paas-preprod-west.a.intuit.com/ui/results?query=cluster%7B*%7D&page=0&limit=25

@fzxu fzxu added bug Something isn't working UI front-end related size: 1 sprint22 labels Mar 18, 2019
@davemasselink
Copy link
Collaborator

I see this behavior. the cause is a : char in the resourceID not being correctly urlencoded

for this bug I will try to fix urlencoding

next sprint, I'd like to update the QSL service code such that UID can be used as a filter param. once that's possible, the generated URL will use UID as distinguisher

@davemasselink
Copy link
Collaborator

davemasselink commented Mar 20, 2019

I'm not positive the cause is the : char. resourceIds with that char in them work just fine when testing in localhost... so I don't think it's a fundamental issue with react-router

actually, it is probably an issue of the URL not containing the /ui portion as built... and that would explain different behavior in localhost vs deployed envs

therefore, should be able to fix this in isolation, but FWIW, the issue to update the QSL service is: #139

davemasselink added a commit to davemasselink/katlas that referenced this issue Mar 21, 2019
…rger, more obvious, control mechanism; also fix bug intuit#145 by including  when necessary in graph URL
davemasselink added a commit that referenced this issue Mar 25, 2019
* #140 - make collapsable drawer default to closed, but with a larger, more obvious, control mechanism; also fix bug #145 by including  when necessary in graph URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size: 1 sprint22 UI front-end related
Projects
None yet
Development

No branches or pull requests

2 participants