Bound Memento 1.x releases to pre-1.3 #41
Conversation
Previously, Memento would store UTC ZonedDateTimes in the records and explicitly depended on TimeZones.jl. In 1.3, it switched to only storing `DateTime` in order to make TimeZones.jl an optional dependency. Since the rest of the Julia ecosystem defaults to `localzone` rather than UTC it made sense to update both packages to follow that same conventions. invenia/Memento.jl#182 (comment)
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 94.35% 94.21% -0.14%
==========================================
Files 5 5
Lines 177 173 -4
==========================================
- Hits 167 163 -4
Misses 10 10
Continue to review full report at Codecov.
|
|
This does not actually change the version compatibility at all. See https://pkgdocs.julialang.org/v1/compatibility/#Version-specifier-format You want this: |
Co-authored-by: Eric Davies <iamed2@gmail.com>
|
@rofinn Will you handle the manual General registry edit or do I need to do that? |
Wait, what? So we need to retroactively upper bound every passed release manually? This is such a bad system for such a common problem. |
Why should releasing a version 2 with some compat affect the compat for version 1? You don't need to make a change for every version, it's a 2-line change in https://github.com/JuliaRegistries/General/blob/master/C/CloudWatchLogs/Compat.toml since Memento v1+ is only mentioned twice. |
|
No, I understand why adding an upperbound to v2 won't automatically update v1. My issue is with the fact that the fix is to manually edit some registry file. |
|
Looks like I was looking for something like Tim Holy's |
| @@ -14,7 +14,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4" | |||
| [compat] | |||
| AWS = "1" | |||
| MbedTLS = "1" | |||
| Memento = "1" | |||
| Memento = "~1.0, ~1.1, ~1.2" | |||
There was a problem hiding this comment.
Could this be simplified to?
| Memento = "~1.0, ~1.1, ~1.2" | |
| Memento = "1 - 1.2" |
There was a problem hiding this comment.
No, since hyphens require Julia 1.4
Since the registry update has been merged I'm just gonna include the Memento compat change for now.
|
Okay, the registry change was merged, so I think we're good to just merge the memento compat in until I update to the new memento release. |
|
Bump. Is this good to merge? |
|
Sorry, missed your comment from 4 days ago, yes let's merge |
Previously, Memento would store UTC ZonedDateTimes in the records and explicitly depended on TimeZones.jl. In 1.3, it switched to only storing
DateTimein order to make TimeZones.jl an optional dependency. Since the rest of the Julia ecosystem defaults tolocalzonerather than UTC it made sense to update both packages to follow that same conventions.invenia/Memento.jl#182 (comment)