Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocabularies: switch to datastreams for affiliations #282

Merged

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented May 29, 2024

❤️ Thank you for your contribution!

Description

This removes the fixtured affiliations vocabulary now that datastreams are available as well as the outdated ror yaml file. To be merged only when inveniosoftware/invenio-vocabularies#327 and inveniosoftware/invenio-app-rdm#2680 are released.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Member

@ptamarit ptamarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact of having the download the ROR file manually is documented in inveniosoftware/docs-invenio-rdm#639, so removing the default file from the cookiecutter is OK.

Maybe it could be nice to include a link to https://inveniordm.docs.cern.ch/customize/vocabularies/ (similarly to what is done in invenio.cfg), not sure...

@slint slint merged commit f9a09cd into inveniosoftware:master Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch affiliations to datastream
3 participants