Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: major refactoring #27

Merged
merged 1 commit into from
Oct 26, 2015
Merged

global: major refactoring #27

merged 1 commit into from
Oct 26, 2015

Conversation

lnielsen
Copy link
Member

No description provided.

@lnielsen lnielsen self-assigned this Oct 21, 2015
@lnielsen lnielsen added this to the v1.0.0 milestone Oct 21, 2015
jirikuncar
jirikuncar reviewed Oct 21, 2015
View reviewed changes
CHANGES.rst
@@ -24,13 +24,8 @@
Changes
=======

Version 0.3.1 (released 2015-10-06)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a big issue but probably we should keep the changes in place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Just didn't clean this up yet.

This was referenced Oct 23, 2015
Closed
Closed
@lnielsen lnielsen force-pushed the rewrite branch 5 times, most recently from 8506d1c to dc49b8f Compare October 23, 2015 21:12
@lnielsen lnielsen changed the title WIP global: major refactoring global: major refactoring Oct 23, 2015
@lnielsen lnielsen assigned nharraud and unassigned lnielsen Oct 26, 2015
nharraud
nharraud reviewed Oct 26, 2015
View reviewed changes
invenio_base/app.py

def my_wsgi_factory(app):
return DispatcherMiddleware(app.wsgi_app, {'/api': api_app})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing :return: in doc

@nharraud
Copy link
Member

Reviewed, mainly little details.
Note for the future: as Invenio-base and the cookiecutter template will evolve and users won't be able to update their generated projects, it would be nice to have an example showing how to use create_app_factory with a basic use-case (one module, api and ui) in invenio-base. That way people can just read the diff to see how the example evolved. Diffing cookiecutter code or the code it generates is not that easy.

@lnielsen
global: major refactoring
2ec78c1 
* INCOMPATIBLE Major rewrite of Invenio-Base to focus on only
  application creation and loading.

Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
@nharraud
Copy link
Member

Everything seems ok. :shipit: ?

@nharraud nharraud merged commit 2ec78c1 into inveniosoftware:next Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nharraud nharraud

Labels
Type: enhancement
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lnielsen @nharraud @jirikuncar