transitions: add transitions kwargs #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
force-pushed
the
bulk_extension
branch
9 times, most recently
from
e08f8bf
to
96a55a9
Compare
ntarocco
approved these changes
Sep 29, 2021
invenio_circulation/links.py
Outdated
| @@ -23,6 +23,7 @@ def loan_links_factory(pid, record=None): | |||
| 'CIRCULATION_LOAN_TRANSITIONS', {} | |||
| ) | |||
| for transition in transitions_config.get(record['state']): | |||
| # determines if the transition should be accessible by the user | |||
There was a problem hiding this comment.
Suggested change
| # determines if the transition should be accessible by the user |
kpsherva
force-pushed
the
bulk_extension
branch
2 times, most recently
from
c411310
to
60f317b
Compare
ntarocco
changed the title
ntarocco
approved these changes
Sep 29, 2021
|
@kprzerwa it should not be a problem, I believe we need to adapt our code that connect to the signal |
BadrAly
approved these changes
Sep 30, 2021
kpsherva
force-pushed
the
bulk_extension
branch
2 times, most recently
from
fdcd446
to
60f317b
Compare
kpsherva
force-pushed
the
bulk_extension
branch
from
e72121a
to
5b2a573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BadrAly we needed to pass additional kwargs to the signal sent in after transition method, could be potentially a breaking change