Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: add assets command to build statics and/or assets independently #69

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Dec 9, 2019

Changes:

  • Adds an assets command.
  • Allows collecting statics
  • Allows building with webpack
  • Allows both of the previous actions at the same time.

Caveats:

Closes #24

@ppanero ppanero requested a review from fenekku December 9, 2019 12:32
@ppanero ppanero mentioned this pull request Dec 9, 2019
@fenekku
Copy link
Contributor

fenekku commented Dec 9, 2019

Not implemented for --prod [...] workflow for this would be to update statics and rebuild the app container (not base) if not

Yes. This should be documented somewhere so it is clear: the workflow is edit your local work and run --dev. When ready generate --prod.

@ppanero
Copy link
Member Author

ppanero commented Dec 10, 2019

Created issues / addressed comments.

Yes. This should be documented somewhere so it is clear: the workflow is edit your local work and run --dev. When ready generate --prod.

Agree, will start writing something (I understand that you agree with the workflow mentioned above?). Maybe we can start creating more pages in the Wiki until we have a doc tool.

Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is good by me!

@ppanero ppanero merged commit b0a252e into inveniosoftware:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants