cli: alembic_version table manual drop #74
Conversation
| ) | ||
| op.execute(CreateSequence(Sequence("transaction_id_seq"))) |
There was a problem hiding this comment.
This will work only for Postgres - can we investigate an option with autoincrement?
There was a problem hiding this comment.
@jirikuncar right, I added autoincrement=True and flask db drop works fine after the alembic commands, but there is no sequence created:
+-------------+-----------------------------+-------------+
| Column | Type | Modifiers |
|-------------+-----------------------------+-------------|
| issued_at | timestamp without time zone | |
| id | bigint | not null |
| remote_addr | character varying(50) | |
+-------------+-----------------------------+-------------+
Indexes:
"pk_transaction" PRIMARY KEY, btree (id)
Time: 0.015s
postgres@localhost:invenio> \ds
+----------+--------+--------+---------+
| Schema | Name | Type | Owner |
|----------+--------+--------+---------|
+----------+--------+--------+---------+
so it differs slightly from flask db create.
dinosk
changed the title
dinosk
force-pushed
the
alembic-fix
branch
4 times, most recently
from
2fd147f
to
fb87a27
Compare
| @@ -69,3 +70,12 @@ def rebuild_encrypted_properties(old_key, model, properties): | |||
| model.query.filter_by(**primary_key_fields).\ | |||
| update(update_values) | |||
| db.session.commit() | |||
|
|
|||
|
|
|||
| def create_alembic_version_table(): | |||
There was a problem hiding this comment.
I add this so that we can use alembic (upgrade|downgrade) after creating the db with db create
invenio_db/utils.py
Outdated
| @@ -28,7 +28,7 @@ | |||
| from flask import current_app | |||
| from sqlalchemy.engine import reflection | |||
|
|
|||
| from invenio_db import db | |||
| import invenio_db | |||
There was a problem hiding this comment.
This had to be changed because it was causing a circural import with the from .utils import create_alembic_verson_table in cli.py
| table.drop(bind=_db.engine, checkfirst=True) | ||
| try: | ||
| table.drop(bind=_db.engine, checkfirst=True) | ||
| except InternalError: |
There was a problem hiding this comment.
I had to add the try except because table.drop(bind=_db.engine, checkfirst=True) doesn't work after alembic upgrade heads and schema_dropper.connection.execute(DropTable(table)) doesn't work after db create
| @@ -28,7 +28,7 @@ | |||
| from flask import current_app | |||
| from sqlalchemy.engine import reflection | |||
|
|
|||
| from invenio_db import db | |||
There was a problem hiding this comment.
can we change it to from .shared import db?
nharraud
force-pushed
the
alembic-fix
branch
3 times, most recently
from
9bf1140
to
9083067
Compare
- Adds to the cli drop command the alembic_version table, as it is not registered in db.metadata.sorted_tables and remains in the db after db drop. (closes inveniosoftware#72) - Handles drop sequence bug in transaction table. (closes inveniosoftware/invenio-accounts#195) - Adds a function to create the alembic_version table in the utils.py, to sync `db create` and `alembic ugprade heads`. Signed-off-by: Dinos Kousidis <konstantinos.kousidis@cern.ch>
Fixes sequence bug in transaction table.
Adds to the cli drop command the alembic_version table.
Addresses #72.
Signed-off-by: Dinos Kousidis konstantinos.kousidis@cern.ch