pids: skip modifications when no data is passed #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2022
zzacharo
reviewed
Dec 14, 2022
| if "pids" in data: | ||
| pids = data.get("pids", {}) | ||
| else: | ||
| pids = record.pids or {} |
There was a problem hiding this comment.
Can you test the use case (currently via the UI):
- Fill in an external pid
- Save
- Change your answer from "yes" to "no" without reserving a doi
- Save again. Payload sent is skipping the
pidskey entirely and the UI expects the backend to reserve one when the record is published!
slint
force-pushed
the
fix-pids-component
branch
from
7f3667a
to
899c3ee
Compare
Pineirin
approved these changes
Jan 16, 2023
zzacharo
reviewed
Jan 17, 2023
| pids = data.get("pids", {}) | ||
| self.service.pids.pid_manager.validate(pids, record, errors) | ||
| record.pids = pids | ||
| pids_data = record.pids or {} # current pids state |
There was a problem hiding this comment.
Could you test what I described here #1139 (comment) ?
There was a problem hiding this comment.
Yes, you are right, this currently breaks in the upload form. I.e. you publish the record with the external DOI that was entered and saved in steps 1 + 2 (even though you choose "No" and click Save).
To move forward, we can either:
- Skip this change (there are some implications in Zenodo Legacy REST API PR for that to work, but it's possible)
- Change in the upload form if the user selects "No" to serialize an empty
pids: {}on the next "Save". - Accept this edge case bug for now until we have a clear vision on what to do with PUT semantics
zzacharo
reviewed
Jan 18, 2023
| record.pids = pids | ||
| pids_data = record.pids or {} # current pids state | ||
| if "pids" in data: # there is new input data for PIDs | ||
| pids_data = data.get("pids", {}) |
There was a problem hiding this comment.
Suggested change
| pids_data = data.get("pids", {}) | |
| pids_data = data["pids"] |
| record.pids = pids | ||
| pids_data = record.pids or {} # current pids state | ||
| if "pids" in data: # there is new input data for PIDs | ||
| pids_data = data.get("pids", {}) |
There was a problem hiding this comment.
Suggested change
| pids_data = data.get("pids", {}) | |
| pids_data = data["pids"] |
zzacharo
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes zenodo/zenodo-rdm#99.
depends on inveniosoftware/react-invenio-deposit#612
❤️ Thank you for your contribution!
Description
Please describe briefly your pull request.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: